bug: Keychain - Disable shielded key import for nano S #1953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1952
Testing
Build/install extension from this branch, then, assuming you are on > v3.0.0 of the Namada App:
Nano S:
Not-Nano S:
Notes
See: https://github.com/LedgerHQ/ledger-live/blob/06cfbf04e2d99e4e7916ace7a10cff8d37c5c38a/libs/ledgerjs/packages/types-devices/src/index.ts#L4
Ledger Live has enumerated the available device IDs here:
Screenshots
NOTE I forced this message by setting the blacklisted device as
nanoSP- this should be only be displayed for thenanoS: