Skip to content

fix: remove issue where unshield is deleting memo #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2025
Merged

fix: remove issue where unshield is deleting memo #2338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b0c8a2
fix: add memo with default
neocybereth Nov 18, 2025
96a99f3
fix: cleanup
neocybereth Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file removed apps/namadillo/src/constants.ts
View file
Open in desktop
Empty file.
16 changes: 8 additions & 8 deletions apps/namadillo/src/workers/MaspTxWorker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ async function unshield(
sdk: Sdk,
payload: Unshield["payload"]
): Promise<EncodedTxData<UnshieldingTransferProps>> {
const { account, gasConfig, chain, props } = payload;
const { account, gasConfig, chain, props, memo } = payload;
await sdk.masp.loadMaspParams("", chain.chainId);
const encodedTxData = await buildTx<UnshieldingTransferProps>(
sdk,
Expand All @@ -187,7 +187,7 @@ async function unshield(
chain,
props,
sdk.tx.buildUnshieldingTransfer,
undefined,
memo,
false
);

Expand All @@ -198,7 +198,7 @@ async function shieldedTransfer(
sdk: Sdk,
payload: ShieldedTransfer["payload"]
): Promise<EncodedTxData<ShieldedTransferProps>> {
const { account, gasConfig, chain, props } = payload;
const { account, gasConfig, chain, props, memo } = payload;
await sdk.masp.loadMaspParams("", chain.chainId);
const encodedTxData = await buildTx<ShieldedTransferProps>(
sdk,
Expand All @@ -207,7 +207,7 @@ async function shieldedTransfer(
chain,
props,
sdk.tx.buildShieldedTransfer,
undefined,
memo,
false
);

Expand All @@ -218,7 +218,7 @@ async function ibcTransfer(
sdk: Sdk,
payload: IbcTransfer["payload"]
): Promise<EncodedTxData<IbcTransferProps>> {
const { account, gasConfig, chain, props, publicKeyRevealed } = payload;
const { account, gasConfig, chain, props, publicKeyRevealed, memo } = payload;

await sdk.masp.loadMaspParams("", chain.chainId);
const encodedTxData = await buildTx<IbcTransferProps>(
Expand All @@ -228,7 +228,7 @@ async function ibcTransfer(
chain,
props,
sdk.tx.buildIbcTransfer,
undefined,
memo,
!publicKeyRevealed
);

Expand All @@ -239,7 +239,7 @@ async function osmosisSwap(
sdk: Sdk,
payload: OsmosisSwap["payload"]
): Promise<EncodedTxData<OsmosisSwapMsgValue>> {
const { account, gasConfig, chain, props } = payload;
const { account, gasConfig, chain, props, memo } = payload;

await sdk.masp.loadMaspParams("", chain.chainId);
const encodedTxData = await buildTx<OsmosisSwapMsgValue>(
Expand All @@ -249,7 +249,7 @@ async function osmosisSwap(
chain,
props,
sdk.tx.buildOsmosisSwap,
undefined,
memo,
false
);

Expand Down