fix flakey e2e tests #661
Merged
fix flakey e2e tests #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batconjurer
approved these changes
Oct 21, 2022
Merged
Contributor
|
since this doesn't change the node and barely changes the client i'm going to skip devnet tests |
tzemanovic
added a commit
that referenced
this pull request
Oct 26, 2022
* tomas/flakey-e2e-tests: test/e2e/helpers: add a helper to query and parse block height changelog: add #658 client: add a block query to print hash, height and time of a block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #659
With the new version of tendermint from #510, a non-validator sometimes syncs without applying txs. This can make e2e tests where we're checking txs result in the node's log fail.
To deal with this in a more reliable way, we first check the block height after the tx is applied in a validator node and wait for the non-validator node to be synced to the same height (#659), before checking the state via another client query.