Bump jshint from 2.11.1 to 2.11.2

.github/workflows/test.yaml → .github/workflows/js.yaml

@@ -1,10 +1,10 @@
-name: test
+name: js
 on:
   pull_request:
   push:
     branches: [master]
 jobs:
-  js:
+  test:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
@@ -20,3 +20,19 @@ jobs:
         run: npm ci
       - name: Test JavaScript
         run: npm test
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+      - name: Read .nvmrc
+        run: echo ::set-output name=NVMRC::$(cat .nvmrc)
+        id: nvm
+      - name: Use Node.js ${{ steps.nvm.outputs.NVMRC }}
+        uses: actions/setup-node@v1
+        with:
+          node-version: '${{ steps.nvm.outputs.NVMRC }}'
+      - name: Install dependencies
+        run: npm ci
+      - name: Lint JavaScript
+        run: npx gulp js:lint

.jshintrc

@@ -0,0 +1,3 @@
+{
+    "node": true
+}

dist/multiselect.js

@@ -515,7 +515,7 @@
 
         /**
          * @name AmoMultiselectFactory#_optionsRegularExpression
-         * 
+         *
          * @description
          * Options attribute value regular expression
          *

gulpfile.js

@@ -51,7 +51,6 @@ gulp.task('all', 'Build application', [
     'css:app',
     'js:app',
     'js:libs',
-    'js:lint'
 ]);
 
 gulp.task('dist', 'Build multiselect', [
@@ -108,9 +107,13 @@ gulp.task('js:libs', 'Compile third party JavaScript', function() {
 });
 
 gulp.task('js:lint', 'Run JSHint to check for JavaScript code quality', function() {
-    gulp.src(js.src.app)
+    gulp.src(js.src.app.concat([
+        '*.js',
+        'tests/**/*.js'
+    ]))
         .pipe(gulpJshint())
-        .pipe(gulpJshint.reporter('default'));
+        .pipe(gulpJshint.reporter('default'))
+        .pipe(gulpJshint.reporter('fail'));
 });
 
 gulp.task('serve', 'Run a local webserver', function() {

karma.conf.js

@@ -15,5 +15,5 @@ module.exports = function(config) {
     autoWatch: true,
     browsers: ['ChromeHeadless'],
     singleRun: false
-  })
-}
+  });
+};

src/lib/multiselect.factory.js

@@ -15,7 +15,7 @@
 
         /**
          * @name AmoMultiselectFactory#_optionsRegularExpression
-         * 
+         *
          * @description
          * Options attribute value regular expression
          *

tests/lib/multiselect.directive.spec.js

@@ -69,11 +69,11 @@ describe('amoMultiselect', function() {
         amoMultiselectFactoryInstanceSpy.getOptionsExpression.and.returnValue('options');
 
         amoMultiselectFactoryInstanceSpy.getLabel.and.callFake(function(option) {
-            return 'LABEL ' + option
+            return 'LABEL ' + option;
         });
 
         amoMultiselectFactoryInstanceSpy.getValue.and.callFake(function(option) {
-            return 'VALUE ' + option
+            return 'VALUE ' + option;
         });
     });
 

tests/lib/multiselect.factory.spec.js

@@ -314,7 +314,7 @@ describe('AmoMultiselectFactory', function() {
                     expect(result).toEqual({
                         key: 2,
                         group: 'A'
-                    })
+                    });
                 });
             });
 
@@ -327,7 +327,7 @@ describe('AmoMultiselectFactory', function() {
                     expect(result).toEqual({
                         key: 1,
                         group: 'B'
-                    })
+                    });
                 });
             });
 
@@ -340,7 +340,7 @@ describe('AmoMultiselectFactory', function() {
                     expect(result).toEqual({
                         key: 3,
                         group: 'B'
-                    })
+                    });
                 });
             });
         });