Skip to content

Conversation

@josesimoes
Copy link
Member

@josesimoes josesimoes commented Nov 24, 2025

Description

  • Remove public constructor and moved initialization of _data array to static constructor.
  • Fix unit test for locals using boxed Guid to use Assert().
  • Fix call unit test with call to Guid.TryParse().

Motivation and Context

How Has This Been Tested?

  • Runing unit tests.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

- Remove public constructor and moved initialization of _data array to static constructor.
- Fix unit test for locals using boxed Guid to use Assert().
- Fix call unit test with call to Guid.TryParse().
@coderabbitai
Copy link

coderabbitai bot commented Nov 24, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Nov 24, 2025
@sonarqubecloud
Copy link

@josesimoes josesimoes merged commit ce5c6d8 into nanoframework:develop Nov 24, 2025
7 checks passed
@josesimoes josesimoes deleted the fix-guid-class branch November 24, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants