Skip to content

Update and fix Authenticate methods #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2019
Merged

Update and fix Authenticate methods #108

merged 1 commit into from
Nov 12, 2019

Conversation

@josesimoes
Copy link
Member

@josesimoes josesimoes commented Nov 12, 2019 •
edited
Loading

Description

  • Change sslProtocol parameter to follow .NET API.
  • Fix AuthenticateAsServer implementation which weren't putting the server certificate in the correct parameter when calling the handler.
  • Update/fix documentation comments.
  • Improve code in native call handler.
  • Bump version to 1.4.1-preview.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes
Update Authenticate methods
50d18e6 
- Change sslProtocol parameter to follow .NET API (and remove unnecessary use of collection as enum has Flags attribute and it's packed into an ORed parameter when calling native code).
- Update/fix documentation comments.
- Improve code in native call handler.
- Bump version to 1.4.1-preview.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Member

nfbot commented Nov 12, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes changed the title Update Authenticate methods Update and fix Authenticate methods Nov 12, 2019
@josesimoes josesimoes removed the Type: bug Something isn't working label Nov 12, 2019
@josesimoes josesimoes merged commit ebbcf72 into nanoframework:develop Nov 12, 2019
@josesimoes josesimoes deleted the update-authenticate-methods branch November 12, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Breaking-Change CI: Publish Release CI: Update Dependents

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@josesimoes @nfbot