Skip to content

Update Wireless ConfigurationOptions #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2020
Merged

Update Wireless ConfigurationOptions #126

merged 1 commit into from
Jun 3, 2020

Conversation

@josesimoes
Copy link
Member

@josesimoes josesimoes commented Jun 3, 2020

Description

  • Rename none enums to disable.
  • ORed enable flag with others that require the interface to be enabled.
  • Improve comments for documentation.
  • Bump version to 1.5.0-preview.

Motivation and Context

  • Makes wireless options more understandable.
  • ORing the enable options reflects the real operation on the device.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot nfbot added Type: enhancement New feature or request Breaking-Change labels Jun 3, 2020
@josesimoes
Update Wireless ConfigurationOptions
d4ac301 
- Rename none enums to disable.
- ORed enable flag with others that require the interface to be enabled.
- Improve comments for documentation.
- Bump version to 1.5.0-preview.

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@josesimoes josesimoes force-pushed the changes-wireless-config branch from 0203162 to d4ac301 Compare June 3, 2020 13:49
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@josesimoes josesimoes merged commit e1ae72c into nanoframework:develop Jun 3, 2020
@josesimoes josesimoes deleted the changes-wireless-config branch June 3, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Breaking-Change CI: Publish Release CI: Update Dependents Type: enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@josesimoes @nfbot