Skip to content

Exception handling & memory leak fixes #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 23, 2020
Merged

Exception handling & memory leak fixes #152

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d46507b
Exception handling & memory leak fixes
skigrinder Dec 11, 2020
a15c9aa
Unhandled exceptions now being passed on to the caller. Comment cle…
skigrinder Dec 17, 2020
fe5e4a3
Changed catch block in Socket() ~line 75
skigrinder Dec 17, 2020
d357fb0
Fixed catch block in Socket()
skigrinder Dec 17, 2020
3526b4a
Another Socket() fix
skigrinder Dec 17, 2020
3e2a458
Removed try/catch blocks to allow normal .NET exception propagation.
skigrinder Dec 20, 2020
165240f
NativeSocket.recv() timeout
skigrinder Dec 21, 2020
cdf9e11
Revert code style changes
josesimoes Dec 22, 2020
b5a0dad
Merge branch 'develop' into skigrinder---Exception-handling-&-memory-…
josesimoes Dec 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions nanoFramework.System.Net/Sockets/Socket.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public class Socket : IDisposable

// socket type
[Diagnostics.DebuggerBrowsable(Diagnostics.DebuggerBrowsableState.Never)]
private SocketType _socketType;
private SocketType _socketType = SocketType.Unknown;

// Our internal state doesn't automatically get updated after a non-blocking connect
// completes. Keep track of whether we're doing a non-blocking connect, and make sure
Expand Down Expand Up @@ -344,7 +344,7 @@ public void Connect(EndPoint remoteEP)
EndPoint endPointSnapshot = remoteEP;
Snapshot(ref endPointSnapshot);

if(m_fBlocking)
if (m_fBlocking)
{
// blocking connect
_nonBlockingConnectInProgress = false;
Expand All @@ -355,7 +355,7 @@ public void Connect(EndPoint remoteEP)
_nonBlockingConnectInProgress = true;
_nonBlockingConnectRightEndPoint = endPointSnapshot;
}

NativeSocket.connect(this, endPointSnapshot, !m_fBlocking);

if (m_fBlocking)
Expand Down