-
-
Notifications
You must be signed in to change notification settings - Fork 17
Parameter description misplacement #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
~ fixed parameter description misplacement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I would also recommend removing the excess namespace from the documentation as it (should) be obvious. But preferably make it a doc ref: https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/language-specification/documentation-comments)...
|
@networkfusion, thanks. I will in future PR's. Now I have not enough experience to somehow edit this PR... commit... or what should I actually do to follow your advice? |
Just change and commit and push to your source (same) branch and this PR will update automagically.... |
~ plane text fqdn namespaces changed to crefs to improve readability
|
@networkfusion, done! |
josesimoes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this. I just added a couple more fixes to it. 😉
|
@cbagpipe thank you again for your contribution! 🙏😄 .NET nanoFramework it's all about community involvement and no contribution is too small. Please edit it and add an entry with your GitHub user in the appropriate location (names sorted alphabetically): (feel free to adjust your name, if it's not correct) |
Description
NetworkStreamconstructor parameters descriptions was misplaced. Fixed it.Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist: