Skip to content

Conversation

@josesimoes
Copy link
Member

Description

  • Add missing Equals and GetHashCode on several classes.
  • Rework GetHostEntry to properly parse data from native call.
  • Apply back fix from Fix IPAddress byte constructor #217
  • Fix several comments for documentation.
  • Several fixes in code style.
  • Improvements from analysers.

Motivation and Context

How Has This Been Tested?

  • Running Unit Tests locally on device.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot nfbot added Type: bug Something isn't working Type: enhancement New feature or request labels Jan 4, 2022
@josesimoes
Copy link
Member Author

Unit Tests will fail because WIN32 nanoCRL it's missing the System.Net declaration updated.

- Add missing Equals and GetHashCode on several classes.
- Rework GetHostEntry to properly parse data from native call.
- Apply back fix from nanoframework#217
- Fix several comments for documentation.
- Several fixes in code style.
- Improvements from analysers.
- Disable running Unit Tests.
@josesimoes josesimoes merged commit dc92ebe into nanoframework:develop Jan 4, 2022
@josesimoes josesimoes deleted the various-fixes branch January 4, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: bug Something isn't working Type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GetHashCode failing for IPAddress Native getaddrinfo assumptions should be re-evaluated

2 participants