Skip to content

Conversation

@AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented Feb 5, 2022

Description

This change only enables DHCP when not already enabled

Motivation and Context

Found that resetting DHCP during start up when DHCP was already enabled cause the getting of IP to be unreliable.
WHen testing Ethernet found the DHCP was changed at the same time as a DHCP was being handled and caused the GOT IP event to go missing which was needed to start the SNTP task.

How Has This Been Tested?

Tested with updated (NetworkHelper) version of Network Client sample with Ethernet on ESP32

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@AdrianSoundy AdrianSoundy merged commit 2ef9178 into develop Feb 5, 2022
@AdrianSoundy AdrianSoundy deleted the AdrianSoundy-patch-1 branch February 5, 2022 22:59
@nfbot
Copy link
Member

nfbot commented Feb 6, 2022

@AdrianSoundy I've fixed the checklist for you.
FYI, the correct format is [x], no spaces inside brackets.

@nfbot nfbot added the Type: bug Something isn't working label Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants