Only Enable DHCP if required #232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change only enables DHCP when not already enabled
Motivation and Context
Found that resetting DHCP during start up when DHCP was already enabled cause the getting of IP to be unreliable.
WHen testing Ethernet found the DHCP was changed at the same time as a DHCP was being handled and caused the GOT IP event to go missing which was needed to start the SNTP task.
How Has This Been Tested?
Tested with updated (NetworkHelper) version of Network Client sample with Ethernet on ESP32
Screenshots
Types of changes
Checklist: