Skip to content

Conversation

@lsd-techno
Copy link
Contributor

@lsd-techno lsd-techno commented Jun 9, 2022

replace Network Event delegates to correspond description.

Description

Update network event functions description to show proper description in code editor when implement them in user space.

Motivation and Context

  • User friendly coding

How Has This Been Tested?

Screenshots

1654755757753

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

replace Network Event delegates to correspond description.
@dnfadmin
Copy link

dnfadmin commented Jun 9, 2022

CLA assistant check
All CLA requirements met.

@nfbot nfbot added the Type: bug Something isn't working label Jun 9, 2022
@josesimoes josesimoes changed the title Update NetworkChange.cs Fix Intellisense comments for Network Change events Jun 9, 2022
@josesimoes josesimoes removed the Type: bug Something isn't working label Jun 9, 2022
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks.

@josesimoes josesimoes merged commit 529e20f into nanoframework:main Jun 9, 2022
@nfbot
Copy link
Member

nfbot commented Jun 9, 2022

@lsd-techno thank you again for your contribution! 🙏😄

.NET nanoFramework it's all about community involvement and no contribution is too small.
We would like to invite you to join the project Contributors list.

Please edit it and add an entry with your GitHub user in the appropriate location (names sorted alphabetically):

  <tr>
    <td><img src="https://github.com/lsd-techno.png?size=50&" height="50" width="50" ></td>
    <td><a href="https://github.com/lsd-techno"></a></td>
  </tr>

(feel free to adjust your name, if it's not correct)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants