Skip to content

Conversation

@AdrianSoundy
Copy link
Member

Description

This change goes with the interpreter update for IDF 5.1.1
It updates the socket code to support working with IPV6 for support of OpenThread and for general use.

Motivation and Context

How Has This Been Tested?

  • Tested changes in IPAddress to support IPV6 format addresses for Parsing and Outputting addresses.
  • Tested with some local UDP and TCPIP socket code

TODO

  • Add some test cases for IPV6

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

@AdrianSoundy
Copy link
Member Author

@josesimoes
Got a weird SonarCloud error. Not sure how to fix that.
I says need to add validation on constructor but its already calling basic constructor with the validation.

@AdrianSoundy
Copy link
Member Author

Looked at adding some IPV6 tests but couldn't get existing ones to run on device. Never seems to deploy.
Followed reference here:
https://docs.nanoframework.net/content/unit-test/running-tests.html#:~:text=Running%20the%20tests%20on%20a%20real%20hardware%20You%27ll,deployed%20into%20the%20device%20attached%20to%20your%20machine.

I see other PR for this assemblies has some changes to tests. I'll wait until that's been merged.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AdrianSoundy AdrianSoundy merged commit d56934f into nanoframework:main Jan 16, 2024
@AdrianSoundy AdrianSoundy deleted the Ipv6 branch January 16, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants