Skip to content

Conversation

@CoryCharlton
Copy link
Member

@CoryCharlton CoryCharlton commented Jan 28, 2024

Description

  • Added a check that left and right are both null
  • Added unit tests to validate equality checking of null

Motivation and Context

It was broken: #310 (comment)

How Has This Been Tested?

Unit tests

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

@nfbot nfbot added Type: bug Something isn't working Type: Unit Tests labels Jan 28, 2024
Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix :-)

@Ellerbach Ellerbach merged commit 21bde8b into nanoframework:main Jan 29, 2024
@CoryCharlton CoryCharlton deleted the fix_null_equality_checks branch January 29, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: bug Something isn't working Type: Unit Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants