Fix X509Certificate constructors from string #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @josesimoes, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
josesimoes
force-pushed
the
fix-certificate-parse
branch
3 times, most recently
from
a9041cd to
48a3089
Compare
- When parsing a string with the certificate need to keep the terminator in the binary representation. - X509Certificate constructor with password was unnecessarily parsing the string to byte array twice. Signed-off-by: José Simões <jose.simoes@eclo.solutions>
josesimoes
force-pushed
the
fix-certificate-parse
branch
from
48a3089 to
c1190b5
Compare
josesimoes
added a commit
to Eclo/nf-interpreter
that referenced
this pull request
Dec 12, 2018
- Following nanoframework/System.Net#52. Signed-off-by: José Simões <jose.simoes@eclo.solutions>
10 tasks
josesimoes
added a commit
to Eclo/nf-interpreter
that referenced
this pull request
Dec 12, 2018
- Following nanoframework/System.Net#52. Signed-off-by: José Simões <jose.simoes@eclo.solutions>
josesimoes
added a commit
to Eclo/nf-interpreter
that referenced
this pull request
Dec 12, 2018
- Following nanoframework/System.Net#52. - Missing from nanoframework#1092. Signed-off-by: José Simões <jose.simoes@eclo.solutions>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
Signed-off-by: José Simões jose.simoes@eclo.solutions