Skip to content

Conversation

@josesimoes
Copy link
Member

Description

  • Remove SslVerification from method parameters. It's now exposed as property.
  • Rework methods to replace X509 certificate collections to single instance.
  • Rework methods to use parameters matching the .NET API.
  • Rework calls to SslNative accordingly.

Motivation and Context

  • No point on using a certificate collection on embedded devices for authentication. If not on the CA root certificate store, the usual use case is to use a single specific certificate to authenticate.
  • The default authentication option was not to validate certificate, which is clearly, a bad practice.
  • The new default behaviour is now to authenticate. The SslVerification property allow a developer to change that behaviour, if needed.
  • API is now inline with the .NET one.

How Has This Been Tested?

  • SSL sample pack from sample repo running on a STM32F769I-DISCO.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

- Remove SslVerification from methods. It's now exposed as property.
- Rework methods to replace X509 certificate collections to single instance.
- Rework methods to use parameters matching the .NET API.
- Rework calls to SslNative accordingly.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Member

nfbot commented Dec 13, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Dec 13, 2018
- Following nanoframework/System.Net#53.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes merged commit e661d7a into nanoframework:develop Dec 13, 2018
@josesimoes josesimoes deleted the work-sslstream branch December 13, 2018 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants