Skip to content

Fix calls address parameters #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2019
Merged

Fix calls address parameters #76

merged 1 commit into from
Jun 5, 2019

Conversation

@josesimoes
Copy link
Member

@josesimoes josesimoes commented Jun 5, 2019

Description

  • Fix calls to nativesockets that use bye[] in parameters. They should use EndPoint types.
  • Rename parameters for consistency.
  • Rework code on callers accordingly.
  • Fix code in IPAddress constructor with byte[] parameter.
  • Simplified GetHostEntry to use new IPAddress constructor from byte[].
  • Bump version to 1.1.1.0-preview.
  • Bump native version to 1.1.1.0.

Motivation and Context

How Has This Been Tested?

  • SSL sample pack.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes
Fix calls address parameters
e810843 
- Fix calls to nativesockets that use bye[] in parameters. They should use EndPoint types.
- Rename parameters for consistency.
- Rework code on callers accordingly.
- Fix code in IPAddress constructor with byte[] parameter.
- Simplified GetHostEntry to use new IPAddress constructor from byte[].
- Bump version to 1.1.1.0-preview.
- Bump native version to 1.1.1.0.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added the Type: bug Something isn't working label Jun 5, 2019
@nfbot
Copy link
Member

nfbot commented Jun 5, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Jun 5, 2019
@josesimoes
Update native declarations for System.Net assembly
8799eb3 
- Following nanoframework/System.Net#76.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes mentioned this pull request Jun 5, 2019
Merged
10 tasks
@josesimoes josesimoes merged commit 47211a1 into nanoframework:develop Jun 5, 2019
@josesimoes josesimoes deleted the fix-calls-with-address-args branch June 5, 2019 15:19
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Jun 5, 2019
@josesimoes
Update native declarations for System.Net assembly
7f1a645 
- Following nanoframework/System.Net#76.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Type: bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@josesimoes @nfbot