Fix static variables not being initialized in derived class HttpWebRequest#88
Merged
Merged
Conversation
Member
|
Hi @RalfMengwasser, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
|
|
|
Kudos, SonarCloud Quality Gate passed!
|
Member
|
@RalfMengwasser next time please don't override the PR template. It's there for a reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Static variables were not initialized properly.
Solution
Add initialize function that can be called from derived class and from static constructor, as there is no guarantee that the static constructor gets called before the derived class uses base class functions.
Add call to initialize to HttpWebRequest constructor as it uses base class functions afterwards.