Skip to content

Conversation

@Ellerbach
Copy link
Member

Description

Adding custom formatting for logs

Motivation and Context

  • Add the possibility to customize the way the logs are formed
  • Fixed issue with stream to stay open

How Has This Been Tested?

With the unit tests

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot nfbot added Type: bug Something isn't working Type: enhancement New feature or request labels Apr 9, 2021
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes
Copy link
Member

@Ellerbach care to look at Sonarcloud issues? 😉

@Ellerbach
Copy link
Member Author

@Ellerbach care to look at Sonarcloud issues? 😉

it's clean for the smells ;-)
image

It doesn't like the duplication of code between Serial and Stream. I just don't want to over complicate it.
image

1 similar comment
@Ellerbach
Copy link
Member Author

@Ellerbach care to look at Sonarcloud issues? 😉

it's clean for the smells ;-)
image

It doesn't like the duplication of code between Serial and Stream. I just don't want to over complicate it.
image

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes merged commit 94e9822 into develop Apr 10, 2021
@josesimoes josesimoes deleted the add-formatting branch April 10, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: bug Something isn't working Type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants