Skip to content

Conversation

@Ellerbach
Copy link
Member

@Ellerbach Ellerbach commented May 28, 2021

Description

Migrating to System.IO.Ports

Motivation and Context

Migrating to System.IO.Ports as Windows.Devices.SerialCommunication is deprecated.

How Has This Been Tested?

Tests

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes enabled auto-merge (squash) May 28, 2021 16:19
@josesimoes josesimoes merged commit f1e04f5 into develop May 29, 2021
@josesimoes josesimoes deleted the migrate-system-io-ports branch October 15, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants