Skip to content

Changed nfproj to sign the assembly #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2021
Merged

Changed nfproj to sign the assembly #7

merged 1 commit into from
May 4, 2021

Conversation

@edleno2
Copy link
Contributor

@edleno2 edleno2 commented May 4, 2021 •
edited by josesimoes
Loading

Description

  • Configuration change only to cause the build system to sign this assembly with a private key.
  • Signing this assembly so we can give it access to System namespace via nanoFramework.Core. A later change will replace the Debug.WriteLine to Console.WriteLine so we can build a Production version of the Nuget library but still be able to output to the debugger.

Motivation and Context

How Has This Been Tested?

Ran build, then ran sn -Tp nanoFramework.Logging.dll to confirm that assembly is now signed. Screen shot attached.
Made all changes and confirmed that when all related changes are made that debug messages are produced with both Debug and Release versions of nanoFramework.Logging.DLL.

Visual Studio 2019
Manual confirmation. that the assembly is signed
Ran test harness from the issue and confirmed that output is now complete.

Screenshots

Logging assembly is signed

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@edleno2
Changed nfproj to sign the assembly
2ee89e4 
Signing this assembly so we can give it access to System namespace via nanoFramework.Core.  A later change will replace the Debug.WriteLine to Console.WriteLine so we can build a Production version of the Nuget library but still be able to output to the debugger.

Fix #737

Signed-off-by: Ed Lenoir <edleno@gmail.com>
@nfbot
Copy link
Member

nfbot commented May 4, 2021

Hi @edleno2,

😞 You have to make up your mind on how this PR addresses the issue. It either fixes, closes or resolves it. Can't have them all...

@nfbot nfbot added Type: bug Something isn't working Area: Config-and-Build labels May 4, 2021
@josesimoes josesimoes removed the Type: bug Something isn't working label May 4, 2021
josesimoes
josesimoes approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes merged commit beade2f into nanoframework:develop May 4, 2021
@josesimoes
Copy link
Member

@nfbot updatedependencies

@edleno2 edleno2 deleted the debuglogger-issue737 branch May 4, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees

No one assigned

Labels

Area: Config-and-Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edleno2 @nfbot @josesimoes