Skip to content

Conversation

@oblaise
Copy link
Contributor

@oblaise oblaise commented Jan 24, 2022

Description

Only create SerialPort in SerialLoggerFactory if it wasn't already created.

Motivation and Context

Avoid exception if SerialLoggerFactory.CreateLogger is called multiple times enabling multiple loggers on the same serial port.

How Has This Been Tested?

N/A

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot nfbot added Type: bug Something isn't working Type: enhancement New feature or request labels Jan 24, 2022
@dnfadmin
Copy link

dnfadmin commented Jan 24, 2022

CLA assistant check
All CLA requirements met.

@josesimoes josesimoes removed the Type: bug Something isn't working label Jan 24, 2022
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Thanks for the nice improvement! 👍🏻

@josesimoes josesimoes requested a review from Ellerbach January 24, 2022 10:03
Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this improvement!

@Ellerbach Ellerbach merged commit bfe177b into nanoframework:develop Jan 25, 2022
@nfbot
Copy link
Member

nfbot commented Jan 25, 2022

@oblaise thank you again for your contribution! 🙏😄

.NET nanoFramework it's all about community involvement and no contribution is too small.
We would like to invite you to join the project Contributors list.

Please edit it and add an entry with your GitHub user in the appropriate location (names sorted alphabetically):

  <tr>
    <td><img src="https://github.com/oblaise.png?size=50&" height="50" width="50" ></td>
    <td><a href="https://github.com/oblaise"></a></td>
  </tr>

(feel free to adjust your name, if it's not correct)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants