Skip to content

Add signature to the Serial and Stream packages #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 25, 2022
Merged

Add signature to the Serial and Stream packages #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4423c28
Cache SerialPort in SerialLoggerFactory
oblaise Jan 24, 2022
641251f
Merge branch 'nanoframework:develop' into develop
oblaise Jan 25, 2022
fb7ac9c
SerialLogger[Factory] documentation update
oblaise Jan 25, 2022
f9832db
Add Signature to Serial and Stream packages
oblaise Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nanoFramework.Logging.Serial/SerialLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
namespace nanoFramework.Logging.Serial
{
/// <summary>
/// A logger that outputs to a <see cref="SerialDevice"/>.
/// A logger that outputs to a <see cref="SerialPort"/>.
/// </summary>
public class SerialLogger : ILogger
{
Expand Down
2 changes: 1 addition & 1 deletion nanoFramework.Logging.Serial/SerialLoggerFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public class SerialLoggerFactory : ILoggerFactory
private readonly Handshake _handshake;

/// <summary>
/// Create a new instance of <see cref="SerialLoggerFactory"/> from a <see cref="SerialDevice"/>.
/// Create a new instance of <see cref="SerialLoggerFactory"/> from a <see cref="SerialPort"/>.
/// </summary>
/// <param name="comPort"></param>
/// <param name="baudRate"></param>
Expand Down
9 changes: 9 additions & 0 deletions nanoFramework.Logging.Serial/nanoFramework.Logging.Serial.nfproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,15 @@
<TargetFrameworkVersion>v1.0</TargetFrameworkVersion>
<DocumentationFile>bin\$(Configuration)\nanoFramework.Logging.Serial.xml</DocumentationFile>
</PropertyGroup>
<PropertyGroup>
<SignAssembly>true</SignAssembly>
</PropertyGroup>
<PropertyGroup>
<AssemblyOriginatorKeyFile>key.snk</AssemblyOriginatorKeyFile>
</PropertyGroup>
<PropertyGroup>
<DelaySign>false</DelaySign>
</PropertyGroup>
<Import Project="$(NanoFrameworkProjectSystemPath)NFProjectSystem.props" Condition="Exists('$(NanoFrameworkProjectSystemPath)NFProjectSystem.props')" />
<ItemGroup>
<Compile Include="SerialLogger.cs" />
Expand Down
9 changes: 9 additions & 0 deletions nanoFramework.Logging.Stream/nanoFramework.Logging.Stream.nfproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,15 @@
<TargetFrameworkVersion>v1.0</TargetFrameworkVersion>
<DocumentationFile>bin\$(Configuration)\nanoFramework.Logging.Stream.xml</DocumentationFile>
</PropertyGroup>
<PropertyGroup>
<SignAssembly>true</SignAssembly>
</PropertyGroup>
<PropertyGroup>
<AssemblyOriginatorKeyFile>key.snk</AssemblyOriginatorKeyFile>
</PropertyGroup>
<PropertyGroup>
<DelaySign>false</DelaySign>
</PropertyGroup>
<Import Project="$(NanoFrameworkProjectSystemPath)NFProjectSystem.props" Condition="Exists('$(NanoFrameworkProjectSystemPath)NFProjectSystem.props')" />
<ItemGroup>
<Compile Include="StreamLogger.cs" />
Expand Down