-
-
Notifications
You must be signed in to change notification settings - Fork 37
Add M5Stack Tough #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add M5Stack Tough #157
Conversation
6360482 to
5ae80bc
Compare
- Update solution and nuspec.
- Rework Screen class for Core2 and Tough. - Update nugets.
|
@Ellerbach I've refactor a bit the Core2ToughCommon class. Namely:
Also some refactoring with the Screen class:
|
|
@Ellerbach we need to rethink the touch implementation too. The Tough doesn't have "buttons" as the Core2. |
M5StackCommon/Core2ToughCommon.cs
Outdated
|
|
||
| #endif | ||
|
|
||
| // Setup buttons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically, it's not the buttons, just the GPIO controller ;-)
Btw, we can avoid this as not used in the Core2 or the Tough and do like the others with lazy loading in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me... I know the guy who coded this, I'll bring this to his attention... 😝
Ellerbach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very little things otherwise looks all good!
Ellerbach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only thing missing now if adjusting the property to get the GpioController. So far it's not done! IT's a common one to the rest. So need to be adjusted ;-)
| _power.ChargingCuttOffVoltage = ChargingCutOffVoltage.V4_2; | ||
|
|
||
| // Setup buttons | ||
| _gpio = new(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must stay here because of the buttons
|
Ignoring Sonarcloud duplication error. |
| _power.ChargingCuttOffVoltage = ChargingCutOffVoltage.V4_2; | ||
|
|
||
| // Setup buttons | ||
| _gpio = new(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must stay here because of the buttons
- Update code in all variants.
Ellerbach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Can't approve as I'm the original author! So feel free to approve and merge!
Description
Add M5Stack Tough
Motivation and Context
How Has This Been Tested?
Need to be tested.
Screenshots
Types of changes
Checklist: