Skip to content

Conversation

@josesimoes
Copy link
Member

Description

  • Remove duplicated assignments of SPI pins in Core2 and Tough.
  • Fix calls to SetPinFunction for SPI so set SPI1.

Motivation and Context

  • Aligns GPIO assignment with SpiConnectionSettings to use SPI1 in all M5Stack devices.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

@nfbot nfbot added the Type: bug Something isn't working label Jul 5, 2022
- Remove duplicated assignments of SPI pins in Core2 and Tough.
- Fix calls to SetPinFunction for SPI to use SPI1 on all variants.
- Fix calls to SpiConfiguration to use SPI1 on all variants.
- Refactor SPI and screen init code in the process.
- Bump version to 1.1.
@josesimoes
Copy link
Member Author

Ignoring duplicate report from Sonarcloud.

@josesimoes josesimoes merged commit d4acfdc into nanoframework:main Jul 5, 2022
@josesimoes josesimoes deleted the fix-spi branch July 5, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants