Skip to content

Conversation

@jacobguilbeau
Copy link
Contributor

@jacobguilbeau jacobguilbeau commented Aug 2, 2022

Description

  • Furthered the support for GPIO lazy loading by changing references to the internal object to use the lazy loader property instead ensuring proper GPIO instantiation.
  • Removed two instances of GPIO instantiation outside of the lazy loader

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

Furthered the support for GPIO lazy loading by changing references to the internal object to use the lazy loader property instead ensuring proper GPIO instantiation.
Remove unneeded comment
@nfbot nfbot added the Type: bug Something isn't working label Aug 2, 2022
@dnfadmin
Copy link

dnfadmin commented Aug 2, 2022

CLA assistant check
All CLA requirements met.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 👍🏻 Thanks for fixing this. 💯 😃

@josesimoes josesimoes changed the title Further support GPIO lazy loading by changing reference from private object to lazy loader property Fix GPIO Controller lazy loading Aug 3, 2022
@josesimoes josesimoes merged commit 6b0eb4d into nanoframework:main Aug 3, 2022
@nfbot
Copy link
Member

nfbot commented Aug 3, 2022

@jacobguilbeau thank you again for your contribution! 🙏😄

.NET nanoFramework it's all about community involvement and no contribution is too small.
We would like to invite you to join the project Contributors list.

Please edit it and add an entry with your GitHub user in the appropriate location (names sorted alphabetically):

  <tr>
    <td><img src="https://github.com/jacobguilbeau.png?size=50&" height="50" width="50" ></td>
    <td><a href="https://github.com/jacobguilbeau"></a></td>
  </tr>

(feel free to adjust your name, if it's not correct)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

M5Stack LED doesn't initialize GPIO leading to errors

4 participants