Skip to content

Conversation

@henrivw
Copy link
Contributor

@henrivw henrivw commented Nov 11, 2022

Description

Motivation and Context

Information

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

@dnfadmin
Copy link

dnfadmin commented Nov 11, 2022

CLA assistant check
All CLA requirements met.

@nfbot nfbot added the Type: documentation Improvements or additions to documentation label Nov 11, 2022
@Ellerbach
Copy link
Member

@henrivw please don't forget to sign the license so we can merge ;-) And thanks a lot for your contribution!

@Ellerbach
Copy link
Member

@henrivw thanks again and please don't forget to sign the license/cla otherwise we won't be able to merge.

henrivw and others added 3 commits December 16, 2022 16:01
Co-authored-by: Laurent Ellerbach <laurelle@microsoft.com>
Co-authored-by: Laurent Ellerbach <laurelle@microsoft.com>
Co-authored-by: Laurent Ellerbach <laurelle@microsoft.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me :-)

@josesimoes josesimoes merged commit 49d589f into nanoframework:main Dec 16, 2022
@nfbot
Copy link
Member

nfbot commented Dec 16, 2022

@henrivw thank you again for your contribution! 🙏😄

.NET nanoFramework it's all about community involvement and no contribution is too small.
We would like to invite you to join the project Contributors list.

Please edit it and add an entry with your GitHub user in the appropriate location (names sorted alphabetically):

  <tr>
    <td><img src="https://github.com/henrivw.png?size=50&" height="50" width="50" ></td>
    <td><a href="https://github.com/henrivw"></a></td>
  </tr>

(feel free to adjust your name, if it's not correct)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants