Skip to content

Conversation

@Feiko
Copy link
Member

@Feiko Feiko commented Jan 30, 2022

Description

Added support for the M5StackAtomLite

  • NeoPixel rgb light
  • Button
  • DAC
  • SPI
  • ADC
  • I2C
  • IR led

Motivation and Context

The next edition to the M5Stack familiy

How Has This Been Tested?

A test for the button and NeoPixel is included in the M5AtomLiteTestApp
IR, SPI, DAC, ADC are copied from other M5*Base projects. The pins have been changed to match the pins on the M5AtomLite in accordance to the M5 documentation. I did not have the means tot test this.

Used a M5AtomLite

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot nfbot added Type: enhancement New feature or request Type: documentation Improvements or additions to documentation labels Jan 30, 2022
Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Feiko as I adjusted some of the code already and the build, the projects, approving. Please adjust the small elements from the documentation. Once @josesimoes will have a quick look, we will be good to merge.

@Feiko
Copy link
Member Author

Feiko commented Jan 31, 2022

Updated the readme

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All up pretty good!! Great to have this new BSP! 👏🏻 😃

Two main issues:

  1. the general naming as explained on the comment. I really think we should follow the official name. It's pretty much in context, so adding the M5 prefix can be confusing and will hinder search engine indexing/discover-ability.

  2. missing version.json and reference to nbgv (just grab one for one of the other bindings and reset the version)

Feiko and others added 11 commits January 31, 2022 10:48
Co-authored-by: José Simões <jose.simoes@eclo.solutions>
Co-authored-by: José Simões <jose.simoes@eclo.solutions>
Co-authored-by: José Simões <jose.simoes@eclo.solutions>
Co-authored-by: José Simões <jose.simoes@eclo.solutions>
Co-authored-by: José Simões <jose.simoes@eclo.solutions>
Co-authored-by: José Simões <jose.simoes@eclo.solutions>
Co-authored-by: José Simões <jose.simoes@eclo.solutions>
Co-authored-by: José Simões <jose.simoes@eclo.solutions>
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! All great. 💯 👏🏻

@josesimoes josesimoes changed the title Added support to M5AtomLite Added support to Atom Lite Jan 31, 2022
@josesimoes josesimoes merged commit 002c2b5 into nanoframework:develop Jan 31, 2022
@josesimoes josesimoes changed the title Added support to Atom Lite Added board support package for Atom Lite Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: documentation Improvements or additions to documentation Type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants