-
-
Notifications
You must be signed in to change notification settings - Fork 37
Added board support package for Atom Lite #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ellerbach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Feiko as I adjusted some of the code already and the build, the projects, approving. Please adjust the small elements from the documentation. Once @josesimoes will have a quick look, we will be good to merge.
changes to readme. Added m5core2 and adjusted samples for m5stackatom…
|
Updated the readme |
josesimoes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All up pretty good!! Great to have this new BSP! 👏🏻 😃
Two main issues:
-
the general naming as explained on the comment. I really think we should follow the official name. It's pretty much in context, so adding the M5 prefix can be confusing and will hinder search engine indexing/discover-ability.
-
missing version.json and reference to nbgv (just grab one for one of the other bindings and reset the version)
Co-authored-by: José Simões <jose.simoes@eclo.solutions>
Co-authored-by: José Simões <jose.simoes@eclo.solutions>
Co-authored-by: José Simões <jose.simoes@eclo.solutions>
Co-authored-by: José Simões <jose.simoes@eclo.solutions>
Co-authored-by: José Simões <jose.simoes@eclo.solutions>
Co-authored-by: José Simões <jose.simoes@eclo.solutions>
Co-authored-by: José Simões <jose.simoes@eclo.solutions>
Co-authored-by: José Simões <jose.simoes@eclo.solutions>
josesimoes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT! All great. 💯 👏🏻
Description
Added support for the M5StackAtomLite
Motivation and Context
The next edition to the M5Stack familiy
How Has This Been Tested?
A test for the button and NeoPixel is included in the M5AtomLiteTestApp
IR, SPI, DAC, ADC are copied from other M5*Base projects. The pins have been changed to match the pins on the M5AtomLite in accordance to the M5 documentation. I did not have the means tot test this.
Used a M5AtomLite
Screenshots
Types of changes
Checklist: