Skip to content

Conversation

@Ellerbach
Copy link
Member

Description

Add M5Stack FIRE

Motivation and Context

How Has This Been Tested?

Need to be tested!

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

@nfbot
Copy link
Member

nfbot commented Mar 1, 2022

Hi @Ellerbach,

😞 You have to make up your mind on how this PR addresses the issue. It either fixes, closes or resolves it. Can't have them all....

@nfbot nfbot added Type: enhancement New feature or request Type: documentation Improvements or additions to documentation labels Mar 1, 2022
@Ellerbach
Copy link
Member Author

Ignoring the code repetition from Sonar Cloud

@Ellerbach Ellerbach merged commit 4be4c4c into develop Mar 14, 2022
@josesimoes josesimoes deleted the add-fire branch March 16, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: documentation Improvements or additions to documentation Type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for M5Stack FIRE

3 participants