Skip to content

Preparing for first release #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 10, 2021
Merged

Preparing for first release #1

merged 11 commits into from
Nov 10, 2021

Conversation

@Ellerbach
Copy link
Member

@Ellerbach Ellerbach commented Nov 10, 2021

Description

Preparing for first release

Motivation and Context

  • Adjust pipeline
  • Prepare for SonarCloud

How Has This Been Tested?

On a real device

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot nfbot added Type: enhancement New feature or request Area: Config-and-Build Type: Documentation Improvements or additions to documentation labels Nov 10, 2021
@Ellerbach Ellerbach requested a review from josesimoes November 10, 2021 17:11
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 10, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

josesimoes
josesimoes reviewed Nov 10, 2021
View reviewed changes
josesimoes
josesimoes reviewed Nov 10, 2021
View reviewed changes
josesimoes
josesimoes approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM now!! 👍🏻 👏🏻 👏🏻 👏🏻

@josesimoes josesimoes enabled auto-merge (squash) November 10, 2021 18:12
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 10, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@josesimoes josesimoes merged commit 3d2d43f into develop Nov 10, 2021
@Ellerbach Ellerbach deleted the prepare-first-pr branch November 10, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees

No one assigned

Labels

Area: Config-and-Build Type: Documentation Improvements or additions to documentation Type: enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ellerbach @josesimoes @nfbot