Skip to content

Conversation

@josesimoes
Copy link
Member

Description

  • Rework Network_Interface_Start_Scan to return detailed success/error code.
  • Update caller accordingly.
  • Processing the return codes on the call stack was being oversimplified. This is now improved with different exceptions being thrown depending on the cause of failure to execute the scan.
  • If needed this can be further improved by adding a WifiScanException or equivalent which could transmit an error code reporting exactly what was the failure.

Motivation and Context

How Has This Been Tested?

  • Running the scan wifi sample.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

- Rework Network_Interface_Start_Scan to return detailed success/error code.
- Update caller accordingly.

(cherry picked from commit d68004e)
(cherry picked from commit 9be414f)
@josesimoes josesimoes added the Platform: ESP32 Everything related specifically with ESP32 platform label Nov 15, 2022
nfbot and others added 2 commits November 15, 2022 15:12
Automated fixes for code style.
…4ea2-64b8-4310-8fe7-63cb8bcd2c19

Code style fixes for nanoframework/nf-interpreter PR#2470
@josesimoes josesimoes force-pushed the improve-esp32-wifi-scan branch from 0dbfb6f to afd617b Compare November 15, 2022 16:13
@josesimoes josesimoes merged commit a97e08d into nanoframework:main Nov 15, 2022
@josesimoes josesimoes deleted the improve-esp32-wifi-scan branch November 15, 2022 16:36
aromaa pushed a commit to aromaa/nf-interpreter that referenced this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Platform: ESP32 Everything related specifically with ESP32 platform Type: enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants