`remove_ready_to_merge` is currently broken

[TimMonko]

🧰 Task

See: https://github.com/napari/docs/actions/runs/19310555153?pr=882

The worfklow is now missing

on:
  workflow_call:

so its currently broken

This was removed in napari/napari#8302 : napari/napari@47cc72e

@jaimergp is this a security issue and that's why it was removed, or are we ok to add it back?

[willingc]

I would love to see Ready to Merge removed 😉 @TimMonko

[Czaki]

This needs to be solved using napari/shared-workflows.

The security issue was pull_request_target, not workflow_call. will try to open PR.

I would love to see Ready to Merge removed 😉 @TimMonko

why?

[willingc]

@Czaki Ready to Merge slows down merge flow, and I believe it is overly conservative for a project of napari's size.

It requires revisting PRs more than once.

[Czaki]

@Czaki Ready to Merge slows down merge flow, and I believe it is overly conservative for a project of napari's size.

Ready to merge, save us from merging broken PR, as additional person, seeing ready to merge do another review.

We have two types of review. Functional review (if the function is needed and the API is properly descinged) and technical one, where one checks the implementation. Most often, the time for technical review is after design/functional part is done. As pinging notifications on GitHub is broken, I do not see another option that lives on platform (there are private pings on zulip).

[willingc]

We have two types of review. Functional review (if the function is needed and the API is properly descinged) and technical one, where one checks the implementation. Most often, the time for technical review is after design/functional part is done. As pinging notifications on GitHub is broken, I do not see another option that lives on platform (there are private pings on zulip).

Why not do both reviews at the same time? Or require 2 reviewers for every PR? Both would achieve the same purpose.