Skip to content

Conversation

Brooooooklyn
Copy link
Member

No description provided.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Brooooooklyn Brooooooklyn requested a review from Copilot October 14, 2025 11:56
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR hides AVX512 SIMD optimizations behind a feature flag to make it optional. This allows users to control whether AVX512 support is included in their builds, which can be useful for compatibility or binary size considerations.

  • Added avx512 feature flag to control AVX512 SIMD support
  • Updated conditional compilation to require both x86/x86_64 architecture and the avx512 feature
  • Adjusted runtime detection logic to properly handle the optional AVX512 support

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
Cargo.toml Added avx512 feature flag and lowered minimum Rust version
src/simd/mod.rs Updated conditional compilation for AVX512 module to require feature flag
src/lib.rs Modified runtime detection logic to handle optional AVX512 support

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codspeed-hq bot commented Oct 14, 2025

CodSpeed Performance Report

Merging #39 will not alter performance

Comparing 10-14-chore_hide_avx512_behind_feature_flag (9c50834) with main (1d36b0c)

Summary

✅ 3 untouched

@Brooooooklyn Brooooooklyn merged commit 37f9991 into main Oct 14, 2025
18 checks passed
@Brooooooklyn Brooooooklyn deleted the 10-14-chore_hide_avx512_behind_feature_flag branch October 14, 2025 12:05
@github-actions github-actions bot mentioned this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant