Fix #27, Add library support to application checksum computing function. #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzbaker
force-pushed
the
fix27-library_scrubbing_support
branch
from
d9ad672 to
bdb3d67
Compare
dmknutsen
approved these changes
Jul 21, 2022
Contributor
dmknutsen
left a comment
dmknutsen
left a comment
There was a problem hiding this comment.
No comments in addition to what Jake mentioned. Great work!
dzbaker
force-pushed
the
fix27-library_scrubbing_support
branch
15 times, most recently
from
c32a039 to
7b106dc
Compare
skliper
suggested changes
Jul 26, 2022
skliper
left a comment
skliper
left a comment
There was a problem hiding this comment.
Just one minor suggestion, good work!
dzbaker
force-pushed
the
fix27-library_scrubbing_support
branch
from
7b106dc to
ae3184f
Compare
skliper
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fixes #27
Testing performed
CI
Expected behavior changes
CS_ComputeApp() will now scrub libraries in addition to apps when computing the checksum.
Unit test updates (all in cs_compute_tests.c):
System(s) tested on
CI