Skip to content

Conversation

@mandyparson
Copy link
Contributor

Overview

What is the feature?

Users can edit Visualization Information.
Users can edit Science Keywords.
Users can use all buttons that are in the form (save, save & continue, save & publish, save & preview)

What is the Solution?

Adding ummVis to all appropriate areas for it to render within MetadataForms.

What areas of the application does this impact?

MetadataForm.js
usePublishMutataion

Please note that this file only needs to be changed until CMR-10545 is complete
Also utilzied getUmmVersion in areas where we wanted to use it when it was completed.

Testing

Reproduction steps

  • **Environment for testing: SIT
  • **Collection to test with: Any
  1. Select a Visualization (there's one corrupted file, let me know if you find it. It doesn't work) and click on Visualization Information. It should be styled the way we want it.
  2. Select Science Keywords. It should work as expected.
  3. Select any/all of the Save Options and make sure they work as expected.

Attachments

Screenshot 2025-05-14 at 9 49 35 AM Screenshot 2025-05-14 at 9 49 52 AM

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.89%. Comparing base (18976b3) to head (11c22c3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1362   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files         389      392    +3     
  Lines        6361     6378   +17     
  Branches     1340     1336    -4     
=======================================
+ Hits         6227     6244   +17     
  Misses        133      133           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mandyparson mandyparson merged commit 898d1fb into main May 19, 2025
7 checks passed
@mandyparson mandyparson deleted the MMT-3995 branch May 19, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants