Skip to content

Conversation

@eudoroolivares2016
Copy link
Contributor

@eudoroolivares2016 eudoroolivares2016 commented May 20, 2025

Overview

What is the feature?

This adds the most recent version of cmr-preview so that we can preview umm-vis records

What is the Solution?

Updating the package deps to include this updated version, updating the graphql query and adding the visualization preview component

I bumped express to satisfy a PR that dependabot was making and I ran npm audit fix.

Some of the tests on main were throwing apollo errors this fixes that as well

What areas of the application does this impact?

Package dependencies, MMT's preview page for Visualization records and collection records

Testing

Reproduction steps

  • **Environment for testing:Local
  • **Collection to test with:NA
  1. Create a umm-vis record ingest it into your local CMR
  2. Associate a collection to that umm-vis record
  3. Create a draft umm-vis record
  4. Ensure that the above's preview pages are displaying correctly
  5. Ensure that the association between the collection and the umm-vis record is visible and useable between the umm-vis and collection records

Attachments

image
image
image
image

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [NA] I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.89%. Comparing base (898d1fb) to head (f3f9bfb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1366   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files         392      392           
  Lines        6378     6380    +2     
  Branches     1349     1353    +4     
=======================================
+ Hits         6244     6246    +2     
  Misses        133      133           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eudoroolivares2016 eudoroolivares2016 changed the title Mmt 4000 MMT-4000: As a user, I can see the metadata preview for Visualizations on MMT May 20, 2025
@eudoroolivares2016 eudoroolivares2016 marked this pull request as ready for review May 20, 2025 16:21
@eudoroolivares2016 eudoroolivares2016 merged commit 133fd75 into main May 21, 2025
7 checks passed
@eudoroolivares2016 eudoroolivares2016 deleted the MMT-4000 branch May 21, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants