-
Notifications
You must be signed in to change notification settings - Fork 42
MMT-4058: Enabling citation association to collection #1411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1411 +/- ##
==========================================
+ Coverage 97.96% 98.08% +0.11%
==========================================
Files 421 421
Lines 6775 6779 +4
Branches 1430 1430
==========================================
+ Hits 6637 6649 +12
+ Misses 137 129 -8
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
static/src/js/components/CollectionAssociationForm/CollectionAssociationForm.jsx
Show resolved
Hide resolved
.../src/js/pages/CollectionAssociationFormPage/__tests__/CollectionAssociationFormPage.test.jsx
Outdated
Show resolved
Hide resolved
.../js/components/CollectionAssociationForm/__tests__/__mocks__/CollectionAssociationResults.js
Show resolved
Hide resolved
.../src/js/pages/CollectionAssociationFormPage/__tests__/CollectionAssociationFormPage.test.jsx
Show resolved
Hide resolved
eudoroolivares2016
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remove the comment at the top of static/src/js/pages/CollectionAssociationFormPage/__tests__/CollectionAssociationFormPage.test.jsx
Overview
What is the feature?
Add support for Associating Citations
While doing this ticket I found that a function of the CollectionAssociationForm wasn't working as expected. When a user is searching for collections to associate, collections that have already been selected should be disabled. But that wasn't happening for two reasons:
What is the Solution?
Edited the get Citation query
Passed metadata down to CollectionAssociationForm
Changed associationDetails to collections, which achieves the same desired result without having to make changes to graphql.
What areas of the application does this impact?
the get citation query
Testing
Reproduction steps
Attachments
Checklist