Skip to content

Conversation

@cgokey
Copy link
Collaborator

@cgokey cgokey commented Oct 29, 2025

Overview

What is the feature?

There are inconsistencies between styling in Access vs. MMT. Areas of concern include:
Collection >> Citation Information >> No cards
Collection >> Addition Information >> Data Centers/Contacts and Archive Info >> No Cards
Another spot where we see is is on the service's
Styling on service options is not correct as well see attached screenshot
There are probably more across other concepts. We should determine this for all concepts in MMT previews and fix all of them

What is the Solution?

The styling issue boiled down to 2 places. 1) The vendor/bootstrap/index.scss was not importing card and preview was full of cards. 2) The first column of a table had a style to turn off borders as a default, I removed this and things look a lot better. I couldn't find any places where turning this off had adverse effects.

What areas of the application does this impact?

MMT Preview
MMT Tables

Testing

Try viewing:
Collection >> Citation Information
Collection >> Addition Information
Service >> Service Options
These should not style things correctly.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.10%. Comparing base (9e2028c) to head (e84e14f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1422   +/-   ##
=======================================
  Coverage   98.10%   98.10%           
=======================================
  Files         422      422           
  Lines        6796     6796           
  Branches     1447     1432   -15     
=======================================
  Hits         6667     6667           
  Misses        128      128           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@eudoroolivares2016 eudoroolivares2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cgokey cgokey merged commit c7a16c4 into main Oct 30, 2025
7 checks passed
@cgokey cgokey deleted the MMT-3866 branch October 30, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants