MMT-3866: Fixed style issues in MMT. #1422
Merged
+1
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
There are inconsistencies between styling in Access vs. MMT. Areas of concern include:
Collection >> Citation Information >> No cards
Collection >> Addition Information >> Data Centers/Contacts and Archive Info >> No Cards
Another spot where we see is is on the service's
Styling on service options is not correct as well see attached screenshot
There are probably more across other concepts. We should determine this for all concepts in MMT previews and fix all of them
What is the Solution?
The styling issue boiled down to 2 places. 1) The
vendor/bootstrap/index.scsswas not importingcardand preview was full of cards. 2) The first column of a table had a style to turn off borders as a default, I removed this and things look a lot better. I couldn't find any places where turning this off had adverse effects.What areas of the application does this impact?
MMT Preview
MMT Tables
Testing
Try viewing:
Collection >> Citation Information
Collection >> Addition Information
Service >> Service Options
These should not style things correctly.
Checklist