MMT-2229 Delete published tools #614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
william-valencia
requested review from
ChristianTrummer99,
charleshuang80,
jdf-eos and
ryanmiller-1
| @@ -0,0 +1,96 @@ | |||
| require 'rails_helper' | |||
Collaborator
There was a problem hiding this comment.
don't need this we're actually trying to remove from any files we see this in
Contributor
Author
There was a problem hiding this comment.
Will remove. Was copied in from the similar delete_service_spec.rb. Do we have a ticket to remove it from all the other places it is already in?
| end | ||
|
|
||
| after :all do | ||
| delete_response = cmr_client.delete_tool('MMT_2', @native_id_2, 'token') |
Collaborator
There was a problem hiding this comment.
I think we should add a comment to remove this after the reset_provider ticket is resolved (can't recall the ticket number right now)
Contributor
Author
There was a problem hiding this comment.
Comment added
…remissions_spec because of CMR-6332
|
|
||
| # Remove this section after CMR-6332 is resolved | ||
| delete_response = cmr_client.delete_tool('MMT_2', @native_id_2, 'token') | ||
| raise unless delete_response.success? |
Contributor
Author
There was a problem hiding this comment.
Noticed that this test was still making searching tools have the error from CMR-6332. Should be able to remove this part after CMR-6332 is resolved.
ryanmiller-1
approved these changes
Jul 14, 2020
charleshuang80
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.