Skip to content

Conversation

@teubert
Copy link
Contributor

@teubert teubert commented Apr 21, 2025

Updating the supported python versions to drop 3.7 and 3.8 which are no longer actively supported by python (see https://devguide.python.org/versions/). ProgPy development policy is to not support versions once they reach python end-of-life.

This release also adds support for python 3.13 for all but data-driven features. A note is added to the troubleshooting guide for users using python3.13 with datadriven features.

@github-actions
Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

@lymichelle21 lymichelle21 added the documentation Improvements or additions to documentation, examples, or tutorial label Apr 22, 2025
Copy link
Contributor

@kjjarvis kjjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good and satisfies requirements. All tests run except tutorials involving known issue with downloading PCoE dataset.

Installing ProgPy Data-Driven Tools with Python 3.13
------------------------
Tensorflow does not support python3.13 as of the writing of this. Until this is fixed, ProgPy data-driven features may not work correctly. If you are having trouble running data-driven features with Python3.13, try with an earlier version of Python.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A few nits:

  • Would it be helpful to add a last updated date like "as of the time of writing this (April 2025)"?
  • Any chance we could capitalize the python3.13 for consistency and change Tensorflow to TensorFlow (realizing I forgot the capitalization in other parts of this file too)?

@teubert teubert merged commit 592233d into dev Apr 22, 2025
31 of 33 checks passed
@teubert teubert deleted the update-python-versions branch April 22, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation, examples, or tutorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants