Skip to content

Conversation

@teubert
Copy link
Contributor

@teubert teubert commented Jul 13, 2023

Fix issue where callback to save model causes lstm training to crash in newest version of tensorflow. change from prog_models hotfix v1.5.2

@teubert teubert requested a review from kjjarvis July 13, 2023 18:05
@teubert teubert added bug Something isn't working components: data model labels Jul 13, 2023
@github-actions
Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

@codecov-commenter
Copy link

Codecov Report

Merging #65 (334b190) into dev (334b190) will not change coverage.
The diff coverage is n/a.

❗ Current head 334b190 differs from pull request most recent head 6f8d142. Consider uploading reports for the commit 6f8d142 to get more accurate results

@@           Coverage Diff           @@
##              dev      #65   +/-   ##
=======================================
  Coverage   84.17%   84.17%           
=======================================
  Files          99       99           
  Lines       10106    10106           
=======================================
  Hits         8507     8507           
  Misses       1599     1599           

Copy link
Contributor

@kjjarvis kjjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice bugfix. Should we open an issue to bring back this capability in the future?

@teubert teubert merged commit aaa4a6b into dev Jul 13, 2023
@teubert teubert deleted the bug/lstm_save branch July 13, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working components: data model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants