Skip to content

Conversation

@teubert
Copy link
Contributor

@teubert teubert commented Aug 17, 2023

Updated MC sample size for UWSamples state to default to just use the UWSamples directly. This is a nice quality of life and efficiency improvement. MC uses UWSamples to represent state, this way it doesn't resample from samples unnecessarily.

Also added corresponding tests. Finally moved documentation of keyword arguments to the predict method, where it's actually used.

@teubert teubert added component: predictors enhancement New feature or request labels Aug 17, 2023
@github-actions
Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

Copy link
Collaborator

@mstraut mstraut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great documentation. Very readable.

@mstraut mstraut merged commit 670e1cf into dev Aug 17, 2023
@teubert teubert deleted the feature/MC_default_samples branch August 17, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants