Skip to content

Conversation

@mstraut
Copy link
Collaborator

@mstraut mstraut commented Aug 17, 2023

arrays and keys did not match, values were being updated incorrectly.

@mstraut mstraut requested a review from teubert August 17, 2023 22:49
@github-actions
Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions. If you haven't already, please send a signed Contributor License Agreement (CLA) to Christopher Teubert (christopher.a.teubert@nasa.gov). CLAs can be found here: https://github.com/nasa/prog_models/tree/master/forms. Also, make sure you're familiar with the developer notes and contributing sections of our developers guide, https://nasa.github.io/progpy/dev_guide.html#notes-for-developers

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Merging #77 (f7b01e3) into dev (ff234f0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev      #77      +/-   ##
==========================================
+ Coverage   84.24%   84.25%   +0.01%     
==========================================
  Files          99       99              
  Lines       10157    10164       +7     
==========================================
+ Hits         8557     8564       +7     
  Misses       1600     1600              
Files Changed Coverage Δ
src/progpy/state_estimators/particle_filter.py 92.94% <100.00%> (ø)
tests/test_state_estimators.py 93.66% <100.00%> (+0.12%) ⬆️

@teubert teubert merged commit 81d8448 into dev Aug 20, 2023
@teubert teubert deleted the feature/particle_filter_fix branch August 20, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants