Skip to content

Conversation

@teubert
Copy link
Contributor

@teubert teubert commented Aug 18, 2023

These changes make future loading optional for predictors that do not have an input (e.g., ThrownObject). This brings the behavior of predictors inline with simulation

@teubert teubert added component: predictors enhancement New feature or request labels Aug 18, 2023
@teubert teubert linked an issue Aug 18, 2023 that may be closed by this pull request
4 tasks
@github-actions
Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

@codecov-commenter
Copy link

Codecov Report

Merging #78 (a34172e) into dev (670e1cf) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev      #78   +/-   ##
=======================================
  Coverage   84.24%   84.24%           
=======================================
  Files          99       99           
  Lines       10157    10157           
=======================================
  Hits         8557     8557           
  Misses       1600     1600           
Files Changed Coverage Δ
src/progpy/predictors/monte_carlo.py 91.66% <100.00%> (+0.17%) ⬆️
src/progpy/predictors/unscented_transform.py 92.64% <100.00%> (+0.10%) ⬆️
tests/test_predictors.py 96.69% <100.00%> (-0.05%) ⬇️

@teubert teubert merged commit ff234f0 into dev Aug 18, 2023
@teubert teubert deleted the feature/empty_future_loading branch August 19, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Future Loading in Predictor

4 participants