-
Notifications
You must be signed in to change notification settings - Fork 23
simulate_to_threshold example #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:
|
kjjarvis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition of simulate_to_threshold
examples/01_Simulation.ipynb
Outdated
| "* horizon\n", | ||
| "* print\n", | ||
| "* progress" | ||
| "In the first section we introduced simulating to a set time. For most applications, users are not interested in the system evolution over a certain timeperiod, but instead in simulating to some event of interest.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "In the first section we introduced simulating to a set time. For most applications, users are not interested in the system evolution over a certain timeperiod, but instead in simulating to some event of interest.\n", | |
| "In the first section we introduced simulating to a set time. For most applications, users are not interested in the system evolution over a certain time period, but instead in simulating to some event of interest.\n", |
examples/01_Simulation.ipynb
Outdated
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "If you recall, the ThrownObject model is of an object thrown into the air. The model has two events, `impact` and `falling`. In a real prognostic models, these events will likely correspond with some failure, fault, or warning threshold. That said, events can be any event of interest that a user would like to predict. \n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "If you recall, the ThrownObject model is of an object thrown into the air. The model has two events, `impact` and `falling`. In a real prognostic models, these events will likely correspond with some failure, fault, or warning threshold. That said, events can be any event of interest that a user would like to predict. \n", | |
| "If you recall, the ThrownObject model is of an object thrown into the air. The model has two events, `impact` and `falling`. In real prognostic models, these events will likely correspond with some failure, fault, or warning threshold. That said, events can be any event of interest that a user would like to predict. \n", |
examples/01_Simulation.ipynb
Outdated
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "By default, `simulate_to_threshold` simulates until the first event occurs. In this case, that's `falling` (i.e., when the object begins falling). For this model `falling` will always occur before `impact`, but for many models you wont have such a strict ordering of events. \n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "By default, `simulate_to_threshold` simulates until the first event occurs. In this case, that's `falling` (i.e., when the object begins falling). For this model `falling` will always occur before `impact`, but for many models you wont have such a strict ordering of events. \n", | |
| "By default, `simulate_to_threshold` simulates until the first event occurs. In this case, that's `falling` (i.e., when the object begins falling). For this model, `falling` will always occur before `impact`, but for many models you won't have such a strict ordering of events. \n", |
examples/01_Simulation.ipynb
Outdated
| "source": [ | ||
| "By default, `simulate_to_threshold` simulates until the first event occurs. In this case, that's `falling` (i.e., when the object begins falling). For this model `falling` will always occur before `impact`, but for many models you wont have such a strict ordering of events. \n", | ||
| "\n", | ||
| "For users interested in when a specific event is reached, you can indicate that using the `threshold_keys` argument. For example," |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "For users interested in when a specific event is reached, you can indicate that using the `threshold_keys` argument. For example," | |
| "For users interested in when a specific event is reached, you can indicate which event you'd like to simulate to using the `threshold_keys` argument. For example," |
Added simulate_to_threshold to example 01_Simulation