Make GetValidationResult public #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheConstructor
force-pushed
the
fix/166
branch
from
e32a1b6 to
7264046
Compare
Owner
|
Thanks for the PR @TheConstructor! I'm going to hold off on merging this until I finish up 2.3. I have some changes in mind for 3.0 which might affect the structure of the API on CommandLineApplication. I want to avoid putting in a change right now in 2.3 which would broken with changes planned for 3.0 |
TheConstructor
force-pushed
the
fix/166
branch
from
7264046 to
d8a2103
Compare
Owner
|
I changed my mind. 3.0 might be a long way off. There isn't any harm in adding this. |
Contributor
Author
|
@natemcmaster speaking of 2.3.0: any idea when it will arrive? It seems ProGet currently chokes on the "beta2" part of the version ^^; ("beta" worked after an update) |
Owner
|
Just posted about this. See #193 :) |
Contributor
Author
|
Thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166. There already are tests and the call-suggestion from #149 (comment) seems to work.