Skip to content

Conversation

@kurtismash
Copy link
Member

No description provided.

@kurtismash kurtismash requested a review from Copilot August 1, 2025 21:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes and improves the module's documentation structure, enhancing clarity and user experience by consolidating navigation items and improving content organization.

  • Restructures the navigation from generic "Usage" section to specific focused sections: Prerequisites, Configuration, and Backing up your resources
  • Updates variable descriptions and documentation content for better clarity and accuracy
  • Consolidates organization policy documentation into the prerequisites section

Reviewed Changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
variables.tf Updates description for terraform_state_bucket_name variable with clearer explanation
mkdocs.yml Restructures navigation from generic "Usage" to specific sections and adds search plugin
docs/why-use-this-module.md Improves clarity and fixes grammatical issues in module explanation
docs/usage-prerequisites.md New comprehensive prerequisites documentation with example delegation policy
docs/usage-configuration.md Refactored configuration documentation with cleaner structure and updated content
docs/usage-backing-up-your-resources.md New detailed guidance for backing up specific resource types
docs/org-policy.md File deleted - content moved to prerequisites section
docs/index.md Updates navigation links and improves content clarity
docs/architecture.md Enhanced architecture documentation with better explanations and updated references
README.md Updates navigation links and improves content clarity to match documentation changes

## What about Vault Lock?

Immutability within AWS Backup is achieved through the use of [Compliance mode](https://docs.aws.amazon.com/aws-backup/latest/devguide/vault-lock.html#backup-vault-lock-modes) vault locking. However, whilst this prevents the recovery points within the vault from being deleted, it does not prevent the KMS Key used to encrypt these from being deleted. An attacker would only need to delete this KMS Key to make the data within the backups inaccessible.
Immutability within AWS Backup is achieved through the use of [Compliance mode](https://docs.aws.amazon.com/aws-backup/latest/devguide/vault-lock.html#backup-vault-lock-modes) vault locking. However, whilst this prevents the recovery points within the vault from being deleted, it does not extend the same protections to the KMS Key used to encrypt them. An malicious user would only need to delete this KMS Key to make the data within the backups inaccessible.
Copy link

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect article usage. Should be "A malicious user" instead of "An malicious user".

Suggested change
Immutability within AWS Backup is achieved through the use of [Compliance mode](https://docs.aws.amazon.com/aws-backup/latest/devguide/vault-lock.html#backup-vault-lock-modes) vault locking. However, whilst this prevents the recovery points within the vault from being deleted, it does not extend the same protections to the KMS Key used to encrypt them. An malicious user would only need to delete this KMS Key to make the data within the backups inaccessible.
Immutability within AWS Backup is achieved through the use of [Compliance mode](https://docs.aws.amazon.com/aws-backup/latest/devguide/vault-lock.html#backup-vault-lock-modes) vault locking. However, whilst this prevents the recovery points within the vault from being deleted, it does not extend the same protections to the KMS Key used to encrypt them. A malicious user would only need to delete this KMS Key to make the data within the backups inaccessible.

Copilot uses AI. Check for mistakes.
@kurtismash kurtismash merged commit bf9e700 into main Aug 1, 2025
9 checks passed
@kurtismash kurtismash deleted the update-docs branch August 1, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants