Skip to content

Commit e7f67a4

Browse files
committed
fix: throw error is view has no parent page
1 parent 6341206 commit e7f67a4

1 file changed

Lines changed: 11 additions & 5 deletions

File tree

src/gesturehandler.android.ts

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -650,18 +650,24 @@ export class Manager extends ManagerBase {
650650
attachGestureHandlerToView(handler: Handler<any, any>, view: View) {
651651
const nHandler = handler.getNative();
652652
if (nHandler) {
653-
const registry = (view.page as PageGestureExtended).registry;
654-
if (registry) {
655-
registry.registerHandler(nHandler);
656-
registry.attachHandlerToView(nHandler.getTag(), view.nativeView);
653+
const page = view.page as PageGestureExtended;
654+
if (page) {
655+
const registry = page.registry;
656+
if (registry) {
657+
registry.registerHandler(nHandler);
658+
registry.attachHandlerToView(nHandler.getTag(), view.nativeView);
659+
}
660+
} else {
661+
throw new Error('a page is needed to attach a gesture');
657662
}
663+
658664
}
659665
}
660666

661667
detachGestureHandlerFromView(handler: Handler<any, any>, view: View) {
662668
const nHandler = handler.getNative();
663669
if (nHandler) {
664-
const registry = (view.page as PageGestureExtended).registry;
670+
const registry = view.page && (view.page as PageGestureExtended).registry;
665671
if (registry) {
666672
registry.dropHandler(handler.getNative());
667673
}

0 commit comments

Comments
 (0)