Skip to content

Nats-Marker-Reason must be mapped to a Key Value Operation #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 5, 2025
Merged

Nats-Marker-Reason must be mapped to a Key Value Operation #1323

merged 3 commits into from
Jun 5, 2025

Conversation

@scottf
Copy link
Contributor

@scottf scottf commented Jun 4, 2025 •
edited
Loading

  • "Remove" map to DEL
  • "MaxAge" and "Purge" maps to PURGE

@scottf
Nats-Marker-Reason must be mapped to a Key Value Operation
bec5766 
- "MaxAge" and "Remove" map to DEL
- "Purge" maps to PURGE
@scottf scottf mentioned this pull request Jun 4, 2025
Closed
@MauriceVanVeen
Copy link
Member

MauriceVanVeen commented Jun 4, 2025 •
edited by scottf
Loading

MaxAge should be mapped to PURGE
https://github.com/nats-io/nats-architecture-and-design/blob/cbb38ba2550d81acfe4dee02f2865f05d45f6f24/adr/ADR-48.md?plain=1#L67

@scottf scottf requested a review from MauriceVanVeen June 4, 2025 23:22
@scottf
Nats-Marker-Reason must be mapped to a Key Value Operation
d6441fc 
- "MaxAge" and "Remove" map to DEL
- "Purge" maps to PURGE
@scottf
Copy link
Contributor Author

scottf commented Jun 4, 2025 •
edited
Loading

MaxAge should also be to PURGE https://github.com/nats-io/nats-architecture-and-design/blob/cbb38ba2550d81acfe4dee02f2865f05d45f6f24/adr/ADR-48.md?plain=1#L67

Fixed

MauriceVanVeen
MauriceVanVeen approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottf scottf merged commit 8ac9d56 into main Jun 5, 2025
5 checks passed
@scottf scottf deleted the kv-marker-reason branch June 5, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauriceVanVeen MauriceVanVeen MauriceVanVeen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scottf @MauriceVanVeen