Skip to content

Fix flapping test: testOverflowFetch #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2025
Merged

Fix flapping test: testOverflowFetch #1340

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf8630d
Fix flapping test: testOverflowFetch
scottf Jun 27, 2025
f63f7cc
Fix flapping test: testOverflowFetch
scottf Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 14 additions & 18 deletions src/test/java/io/nats/client/impl/SimplificationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1294,43 +1294,35 @@ public void testOverflowFetch() throws Exception {
.name(consumer)
.priorityPolicy(PriorityPolicy.Overflow)
.priorityGroups(group)
.ackWait(60_000)
.ackWait(10_000)
.filterSubjects(tsc.subject()).build();
jsm.addOrUpdateConsumer(tsc.stream, cc);

ConsumerContext ctxPrime = nc.getConsumerContext(tsc.stream, consumer);
ConsumerContext ctxOver = nc.getConsumerContext(tsc.stream, consumer);

FetchConsumeOptions fcoNoMin = FetchConsumeOptions.builder()
.maxMessages(5)
.expiresIn(3000)
.group(group)
.maxMessages(5).expiresIn(1000).group(group)
.build();

FetchConsumeOptions fcoOverA = FetchConsumeOptions.builder()
.maxMessages(5)
.expiresIn(3000)
.group(group)
.minAckPending(5)
.maxMessages(5).expiresIn(1000).group(group).minAckPending(5)
.build();

FetchConsumeOptions fcoOverB = FetchConsumeOptions.builder()
.maxMessages(5)
.expiresIn(3000)
.group(group)
.minAckPending(6)
.maxMessages(5).expiresIn(1000).group(group).minAckPending(10)
.build();

_overflowFetch(ctxPrime, fcoNoMin, true, 5);
_overflowFetch(ctxOver, fcoNoMin, true, 5);
_overflowFetch(ctxPrime, fcoNoMin, true, 5, 0);
_overflowFetch(ctxOver, fcoNoMin, true, 5, 0);

_overflowFetch(ctxPrime, fcoNoMin, false, 5);
_overflowFetch(ctxOver, fcoOverA, true, 5);
_overflowFetch(ctxOver, fcoOverB, true, 0);
_overflowFetch(ctxPrime, fcoNoMin, false, 5, 5);
_overflowFetch(ctxOver, fcoOverA, true, 5, 5);
_overflowFetch(ctxOver, fcoOverB, true, 0, 5);
});
}

private static void _overflowFetch(ConsumerContext cctx, FetchConsumeOptions fco, boolean ack, int expected) throws Exception {
private static void _overflowFetch(ConsumerContext cctx, FetchConsumeOptions fco, boolean ack, int expected, int ackPendingWhenDone) throws Exception {
try (FetchConsumer fc = cctx.fetch(fco)) {
int count = 0;
Message m = fc.nextMessage();
Expand All @@ -1342,6 +1334,10 @@ private static void _overflowFetch(ConsumerContext cctx, FetchConsumeOptions fco
m = fc.nextMessage();
}
assertEquals(expected, count);
if (ack) {
sleep(50); // give the server time to process acks given
}
assertEquals(ackPendingWhenDone, cctx.getConsumerInfo().getNumAckPending());
}
}

Expand Down
Loading